Add a little helper to CalculusPatch to make a FieldPlotter#266
Merged
inducer merged 6 commits intoinducer:mainfrom Mar 13, 2026
Merged
Add a little helper to CalculusPatch to make a FieldPlotter#266inducer merged 6 commits intoinducer:mainfrom
inducer merged 6 commits intoinducer:mainfrom
Conversation
3625545 to
140bcbc
Compare
5eb8b2a to
d9532ae
Compare
There was a problem hiding this comment.
Pull request overview
Adds a way to build a FieldPlotter directly from a CalculusPatch grid (including non-uniform grids) and updates typing/documentation/CI to support the new optype-based annotations.
Changes:
- Extend
FieldPlotterto optionally accept an explicit grid (points=None-> pass provided points through). - Add
CalculusPatch.make_field_plotter()and deprecateCalculusPatch.plot()in favor of it. - Typing/doc/CI updates (optype annotations, Sphinx nitpick ignores, basedpyright baseline adjustments, CI installs
optype).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sumpy/visualization.py | Adds points support to FieldPlotter and tightens type annotations. |
| sumpy/point_calculus.py | Introduces make_field_plotter(), deprecates plot(), and improves typing/docs. |
| sumpy/toys.py | Removes a couple of type-ignore comments as part of typing cleanup. |
| sumpy/symbolic.py | Removes an unnecessary type-ignore on an import assignment. |
| doc/conf.py | Adjusts Sphinx nitpick ignores / missing-reference aliases for optype-based types. |
| .github/workflows/ci.yml | Installs optype in the basedpyright job environment. |
| .basedpyright/baseline.json | Updates the type-checker baseline to reflect the new typing state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d9532ae to
1ecb062
Compare
1ecb062 to
ff2fc62
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has a bunch of typing fixes, so it looks bigger than it is.
For the actual functionality: just added a
points=Noneto theFieldPlotterconstructor so that it can take the (possibly non-uniform) grid fromCalculusPatchinstead of making its own.