Fix collision errors in EinsumDistributiveLawMapper.#644
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses cache collision / “no-op duplication” errors triggered by EinsumDistributiveLawMapper when the distributive-law pass makes no semantic changes, and adds a regression test demonstrating the failure on main.
Changes:
- Add a regression test ensuring a no-op distributive-law pass returns the original
DictOfNamedArraysobject. - Update
EinsumDistributiveLawMapperto reuse existing nodes when recursion doesn’t change subexpressions, reducing duplicate node creation. - Add explicit handling for
DictOfNamedArraysin the distributive-law mapper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
test/test_linalg.py |
Adds a regression test asserting identity-preserving behavior for a no-op pass on a DictOfNamedArrays graph. |
pytato/transform/einsum_distributive_law.py |
Adjusts mapper behavior to avoid recreating structurally-equal nodes and adds a mapper method for DictOfNamedArrays. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
kaushikcfd
force-pushed
the
fix_collision_err_ensm_distributive
branch
from
5b6cba2 to
5dcde40
Compare
kaushikcfd
force-pushed
the
fix_collision_err_ensm_distributive
branch
from
5dcde40 to
b9962ac
Compare
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided test fails on main.