Add MapAndReduceMapper and refactor/extend analysis utils#639
Draft
majosm wants to merge 11 commits intoinducer:mainfrom
Draft
Add MapAndReduceMapper and refactor/extend analysis utils#639majosm wants to merge 11 commits intoinducer:mainfrom
MapAndReduceMapper and refactor/extend analysis utils#639majosm wants to merge 11 commits intoinducer:mainfrom
Conversation
will make it easier to deprecate/remove count_dict argument later
majosm
force-pushed
the
dag-analysis-utils
branch
from
19771f3 to
0c70b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
MapAndReduceMapperto more easily implement DAG reduction operations such asget_num_nodes(specifically, it avoids the excess boilerplate of usingCachedWalkMapperand the double counting issues of usingCombineMapper). Reimplements existing analysis utils using it and adds some new ones:get_num_node_instances_of,collect_nodes,collect_node_instances_of,collect_materialized_nodes.Draft for now because:
is_materialized()