Skip to content

Parameter studies#265

Draft
nkoskelo wants to merge 32 commits intoinducer:mainfrom
nkoskelo:uq_inner
Draft

Parameter studies#265
nkoskelo wants to merge 32 commits intoinducer:mainfrom
nkoskelo:uq_inner

Conversation

@nkoskelo
Copy link
Contributor

@nkoskelo nkoskelo commented Jul 8, 2024

This is an enhancement pull request.

Its purpose is to allow a user to specify a program, P($var1$, $var2$, $\dots$) $\rightarrow out$ and transform it into a new program $P'(var1_{s1}, var2_{s2}, \dots)$ $\rightarrow out_{s1,s2}$. $out_{s1,s2, \dots}$ will contain the answers to running $P$ on each input variable grouping in the input shape.

Needs:

@inducer inducer marked this pull request as draft July 8, 2024 15:29
@inducer inducer changed the title DRAFT: UQ to Inner Loop UQ to Inner Loop Jul 8, 2024
@nkoskelo nkoskelo requested a review from inducer July 10, 2024 19:49
@inducer inducer changed the title UQ to Inner Loop Parameter studies Jul 16, 2024
@inducer
Copy link
Owner

inducer commented Jul 16, 2024

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

Comment on lines 87 to 92
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at this docstring rendered?

Comment on lines 454 to 457
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here so that I can actually execute the code made in the examples folder. Perhaps it would be better to just make a subclass in the examples code and then use that instead.

@inducer
Copy link
Owner

inducer commented Jul 23, 2024

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

Comment on lines 119 to 122
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, see #272.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just build the right-size Placeholder to start with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only build the placeholder once. I am allowing the multiple-instance argument to be passed to the function _to_input_for_compiled(arg, actx) whose functionality depends on the input ArrayContext on account of a subsequent call to actx.transform_dag(arg). We are cutting to a placeholder afterwards so that the pytato.transfrom.materialize_with_mpms materialization strategy is still used. Other ArrayContexts may have other strategies implemented before the compilation step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments