transpile: Use f128::f128::ZERO constructor in conditions#1696
Open
Rua wants to merge 1 commit intoimmunant:masterfrom
Open
transpile: Use f128::f128::ZERO constructor in conditions#1696Rua wants to merge 1 commit intoimmunant:masterfrom
f128::f128::ZERO constructor in conditions#1696Rua wants to merge 1 commit intoimmunant:masterfrom
Conversation
ahomescu
approved these changes
Mar 26, 2026
kkysen
approved these changes
Mar 26, 2026
Contributor
|
Could we also add a snapshot test for this? |
Rua
changed the title
0.0 in f128 constructor in conditionsf128::f128::ZERO constructor in conditions
Contributor
Author
|
I've now made a separate PR to add tests for all the PRs affecting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long double→boolcauses Rust type mismatch #1692.