transpile: Import num_traits::Float for method calls on f128#1695
Open
Rua wants to merge 1 commit intoimmunant:masterfrom
Open
transpile: Import num_traits::Float for method calls on f128#1695Rua wants to merge 1 commit intoimmunant:masterfrom
num_traits::Float for method calls on f128#1695Rua wants to merge 1 commit intoimmunant:masterfrom
Conversation
ahomescu
approved these changes
Mar 26, 2026
|
|
||
| match arg_type_kind { | ||
| CTypeKind::LongDouble | CTypeKind::Float128 => { | ||
| self.use_crate(ExternCrate::NumTraits); |
Contributor
There was a problem hiding this comment.
Was this not needed before because there's a cast after? Or how did this work before?
Contributor
Author
There was a problem hiding this comment.
I'm not sure it ever worked. These methods are not inherent methods of f128, they are provided by the Float trait. So without importing that, you just get a compile error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f128float methods without importing required traits #1690.