transpile: Pass correct types when translating prefix inc/dec operators#1689
Open
Rua wants to merge 1 commit intoimmunant:masterfrom
Open
transpile: Pass correct types when translating prefix inc/dec operators#1689Rua wants to merge 1 commit intoimmunant:masterfrom
Rua wants to merge 1 commit intoimmunant:masterfrom
Conversation
Rua
force-pushed
the
prefix-operator-types
branch
from
bc3468b to
97cd9eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.offset_from(1)When Transpiling Pointer Decrement on Struct Field #1237.Firstly, the types being passed were wrong in general, as if the arguments had been switched around. But also, for pointer increment/decrement, the implied RHS is not itself a pointer. So this PR solves that by using
intas the implied type there instead.