Rework of filter boundary behaviour#774
Open
Quickmarble wants to merge 7 commits intoimage-rs:mainfrom
Open
Conversation
Contributor
Author
|
There might be more places where boundary behaviour should be reviewed, but I guess it's enough changes for the scope of this PR. I need to update docs and then it'll be ready. The following functions have been modified to account for
One- and two-dimensional filters now employ |
Contributor
Author
|
Benchmarks before: Benchmarks after: |
Contributor
Author
|
Should be ready now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the work started in #769 (specifying boundary behaviour with
Border<P>) tofilter*()functions and friends. Refactoring all of them while keeping track of performance might take a while.Closes #2.