refactor: remove unused JsonUtil#18
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the unused JSON utility helper from the common module and cleans up the module’s dependencies accordingly, reducing dead code and avoiding an unnecessary Jackson transitive dependency from common.
Changes:
- Deleted
JsonUtiland its customJsonUtilExceptionfromcommon. - Removed the
JsonUtilTesttest suite (now irrelevant after deleting the utility). - Dropped the
jackson-databinddependency fromcommon/pom.xml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/src/test/java/lt/satsyuk/common/util/JsonUtilTest.java | Removes tests for the deleted JsonUtil. |
| common/src/main/java/lt/satsyuk/common/util/JsonUtilException.java | Removes the custom runtime exception used only by JsonUtil. |
| common/src/main/java/lt/satsyuk/common/util/JsonUtil.java | Removes the unused JSON serialization/deserialization helper. |
| common/pom.xml | Removes now-unused jackson-databind dependency from common. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
JsonUtilandJsonUtilExceptionfromcommonjackson-databinddependency fromcommon/pom.xmlVerification
mvn -f common/pom.xml testmvn -f cdc-service/pom.xml test