ci: use self-repository syntax - #82
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBoth CI and publishing workflows now invoke the shared tox workflow through the self-repository reference syntax while preserving their existing checkout-ref inputs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/ci.yml" line_range="26" />
<code_context>
tox:
if: ${{ github.event_name == 'pull_request' }}
- uses: ./.github/workflows/tox.yml
+ uses: $/.github/workflows/tox.yml
with:
checkout-ref: ${{ github.ref }}
</code_context>
<issue_to_address>
**issue (bug_risk):** The reusable workflow reference `uses: $/.github/workflows/tox.yml` is not a valid GitHub Actions repository or local-workflow reference, so the workflows fail validation and the `tox` jobs never run. In `publish.yml`, this also prevents the dependent PyPI upload job from running.
**Suggested fix:** Use the local reusable-workflow syntax `uses: ./.github/workflows/tox.yml` in both files, or use a fully qualified `{owner}/{repo}/.github/workflows/tox.yml@{ref}` reference.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/ci.yml:26
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| tox: | ||
| if: ${{ github.event_name == 'pull_request' }} | ||
| uses: ./.github/workflows/tox.yml | ||
| uses: $/.github/workflows/tox.yml |
There was a problem hiding this comment.
issue (bug_risk): The reusable workflow reference uses: $/.github/workflows/tox.yml is not a valid GitHub Actions repository or local-workflow reference, so the workflows fail validation and the tox jobs never run. In publish.yml, this also prevents the dependent PyPI upload job from running.
Suggested fix: Use the local reusable-workflow syntax uses: ./.github/workflows/tox.yml in both files, or use a fully qualified {owner}/{repo}/.github/workflows/tox.yml@{ref} reference.
Summary by Sourcery
Use repository-qualified references for the shared tox workflow in CI and publishing pipelines.
Enhancements:
CI: