ci: use self-repository syntax - #81
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBoth CI and publish workflows now invoke the shared tox workflow through the self-repository reference syntax, with existing job conditions and checkout-ref inputs unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/ci.yml" line_range="26" />
<code_context>
tox:
if: ${{ github.event_name == 'pull_request' }}
- uses: ./.github/workflows/tox.yml
+ uses: $/.github/workflows/tox.yml
with:
checkout-ref: ${{ github.ref }}
</code_context>
<issue_to_address>
**issue (bug_risk):** GitHub Actions rejects `uses: $/.github/workflows/tox.yml` because `$/.github/workflows/tox.yml` is not a valid local reusable-workflow path or repository-qualified workflow reference, so both workflows fail to load.
**Suggested fix:** Use the valid local reference `uses: ./.github/workflows/tox.yml`, or provide a repository-qualified reference such as `owner/repository/.github/workflows/tox.yml@ref`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .github/workflows/ci.yml:26
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| tox: | ||
| if: ${{ github.event_name == 'pull_request' }} | ||
| uses: ./.github/workflows/tox.yml | ||
| uses: $/.github/workflows/tox.yml |
There was a problem hiding this comment.
issue (bug_risk): GitHub Actions rejects uses: $/.github/workflows/tox.yml because $/.github/workflows/tox.yml is not a valid local reusable-workflow path or repository-qualified workflow reference, so both workflows fail to load.
Suggested fix: Use the valid local reference uses: ./.github/workflows/tox.yml, or provide a repository-qualified reference such as owner/repository/.github/workflows/tox.yml@ref.
Summary by Sourcery
Use repository-qualified references when invoking the reusable tox workflow.
Enhancements:
CI: