fix #99: implement commented string_quote_removal#100
fix #99: implement commented string_quote_removal#100WillForan wants to merge 2 commits intoidank:masterfrom
Conversation
|
Thanks, can you make this work in 3.7 as well? |
|
I worried the walrus operator was suspicious, albeit more concise. hopefully removing it does the trick for py3.7 |
|
There seems to be more to this function than just single quotes: https://github.com/bminor/bash/blob/master/subst.c#L11892 Like double quotes, escape characters. Can you maybe leave a todo if you're not going to add that part? |
|
sorry for the long delay! I'm not sure I've gotten the edge cases correct. And I'm assuming unbalanced non-escaped quotes would have had a parsing error before getting here. currently Surprisingly (to me) these are all valid bash HEREDOCs |
No description provided.