ENGTAI-40849: Add service.instance.id attribute in SpanFromContext function#248
Merged
tim-mwangi merged 3 commits intomainfrom May 1, 2025
Merged
ENGTAI-40849: Add service.instance.id attribute in SpanFromContext function#248tim-mwangi merged 3 commits intomainfrom
tim-mwangi merged 3 commits intomainfrom
Conversation
…nction This is used by the otel http and grpc instrumentation. StartSpan already adds service.instance.id attribute. So adding it in SpanFromContext as well
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 61.14% 53.35% -7.79%
==========================================
Files 59 59
Lines 2697 2699 +2
==========================================
- Hits 1649 1440 -209
- Misses 967 1185 +218
+ Partials 81 74 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varkey98
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SpanFromContext is used by the otel http and grpc instrumentation. StartSpan already adds service.instance.id attribute. So adding it in SpanFromContext as well
Testing
Manual testing