Skip to content

fix(otel): make ClickHouse exporter timeout configurable - #2899

Open
mfroembgen wants to merge 1 commit into
hyperdxio:mainfrom
mfroembgen:ai/configurable-clickhouse-exporter-timeout
Open

fix(otel): make ClickHouse exporter timeout configurable#2899
mfroembgen wants to merge 1 commit into
hyperdxio:mainfrom
mfroembgen:ai/configurable-clickhouse-exporter-timeout

Conversation

@mfroembgen

@mfroembgen mfroembgen commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

The OpAMP-managed and standalone ClickHouse exporters hardcode a five-second request timeout. Larger inserts can legitimately take longer to acknowledge, but deployments cannot tune that deadline.

This changes both exporters to read HYPERDX_OTEL_EXPORTER_TIMEOUT while preserving the existing 5s default. It includes a focused OpAMP test and a changeset for the API and collector packages.

How to test on Vercel preview

N/A — non-UI change.

Validation

  • yarn build:common-utils
  • yarn workspace @hyperdx/api tsc --noEmit
  • focused @hyperdx/api unit test (6/6 passing)
  • touched-file ESLint, Prettier, YAML parse, and git diff --check
  • Full API lint reaches the current repository warning ratchet (363 > 357); changed files add no warnings or errors.

References

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7997890

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/api Patch
@hyperdx/otel-collector Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

@mfroembgen is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes the ClickHouse exporter request timeout configurable while preserving the existing five-second default.

  • Applies HYPERDX_OTEL_EXPORTER_TIMEOUT to both ClickHouse exporters in OpAMP-managed configuration.
  • Applies the same setting to all standalone collector modes through their shared base configuration.
  • Adds focused configuration coverage and package changesets.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/api/src/opamp/controllers/opampController.ts Replaces both OpAMP-generated ClickHouse exporter timeout literals with collector-side environment interpolation and a five-second fallback.
docker/otel-collector/config.standalone.yaml Makes both standalone ClickHouse exporter timeouts configurable through the same environment variable and default.
packages/api/src/opamp/controllers/tests/opampController.test.ts Verifies that both generated ClickHouse exporter configurations contain the configurable timeout expression.
.changeset/configurable-clickhouse-exporter-timeout.md Records patch releases for the API and collector packages and accurately describes the new configuration option.

Reviews (2): Last reviewed commit: "fix(otel): make ClickHouse exporter time..." | Re-trigger Greptile

@mfroembgen
mfroembgen force-pushed the ai/configurable-clickhouse-exporter-timeout branch from b38bbf0 to 7997890 Compare August 14, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the ClickHouse exporter request timeout configurable

2 participants