Skip to content

test: Add E2E tests for external dashboard APIs#1691

Merged
kodiakhq[bot] merged 2 commits intomainfrom
drew/external-dashboards-e2e
Feb 4, 2026
Merged

test: Add E2E tests for external dashboard APIs#1691
kodiakhq[bot] merged 2 commits intomainfrom
drew/external-dashboards-e2e

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Feb 3, 2026

Closes HDX-3311

Summary

This PR adds E2E tests that verify that dashboards created and edited through the external API can be rendered correctly in the UI.

  • The tests create a dashboard with all tile types through the external API, then assert that the tile edit form contains the correct values for all of the tile's properties.
  • The tests verify that the dashboard can be saved from the UI, proving that the dashboard data conforms to the internal dashboard API's schema, after being created by the external dashboards API
  • The tests also validate that dashboard updates and deletes via the external API are reflected in the UI.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: 61a33b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 4, 2026 0:37am

Request Review

@claude
Copy link

claude bot commented Feb 3, 2026

PR Review: E2E Tests for External Dashboard APIs

✅ No critical issues found.

The implementation is well-structured with comprehensive test coverage for the external dashboard API. The code follows project conventions and includes proper error handling, type safety, and clear documentation.

Highlights:

  • Good test organization with proper use of test.step() for clarity
  • Comprehensive coverage of all chart types (time, number, table, search, markdown)
  • Proper cleanup with unique dashboard names to avoid test conflicts
  • Well-documented API helper functions
  • Appropriate test tags for filtering (@full-stack, @api)

Minor observations (non-blocking):

  • The verifyTileForm method is well-designed but could potentially be flaky if CodeMirror rendering is slow - the existing timeouts should handle this
  • API helper error messages are clear and actionable

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

E2E Test Results

All tests passed • 63 passed • 4 skipped • 821s

Status Count
✅ Passed 63
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew requested review from a team, bot-hyperdx and dhable and removed request for a team and bot-hyperdx February 3, 2026 20:52
Copy link
Contributor

@knudtty knudtty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests!

@kodiakhq kodiakhq bot merged commit 3859ceb into main Feb 4, 2026
10 of 12 checks passed
@kodiakhq kodiakhq bot deleted the drew/external-dashboards-e2e branch February 4, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants