Add a mechanism to redact fetch instrumentation#188
Open
nickdichev wants to merge 1 commit intohyperdxio:mainfrom
Open
Add a mechanism to redact fetch instrumentation#188nickdichev wants to merge 1 commit intohyperdxio:mainfrom
nickdichev wants to merge 1 commit intohyperdxio:mainfrom
Conversation
12ca9c3 to
6c21b4c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
I'm using better-auth in my app which uses fetch under the hood to make requests. I noticed that sensitive credentials were leaking into HyperDX via the fetch instrumentation. Obviously, I don't want this to happen.
This PR attempts to add a redaction mechanism on the fetch instrumentation. Was looking for some initial feedback on what you all think about this direction, since I think some of the other auto-instrumentation could/should use a similar pattern. I think there's a couple of other ways this feature could be implemented like modifying the HyperDXSpanProcessor or writing a custom exporter, but that would add a JSON.parse on every span (on http.request.body), which is maybe undesirable?
This work allows the application developer to instantiate their client side hyperdx like this:
Which will then end up like this on the console: