Repository navigation
demos: oEmbed discovery link + preview.png - #286
Merged
Merged
Conversation
- embed.html: add <link rel=alternate type=application/json+oembed> so consumers using oEmbed autodiscovery (not just OpenGraph parsing) can find oembed.json. Includes the spec-required ?url= param even though the static endpoint ignores it. - preview.png: add the 640x480 thumbnail that og:image and the oembed thumbnail_url both reference (previously 404'd, so every card fallback showed a broken image). Captured from the live player mid-playback so it shows video + captions + the interactive transcript. oembed.json needs no change — it was already a valid rich response; its only defect was the missing thumbnail file, now fixed. The remaining item from #285 (static endpoint ignoring ?url=) is left as noted-optional; no current consumer requires a dynamic endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285 (items 1 and 2; item 3 left as noted-optional).
Changes
demos/embed.html— add anapplication/json+oembeddiscovery<link>so consumers using oEmbed autodiscovery (rather than OpenGraph parsing) can findoembed.json. Includes the spec-required?url=param even though the static endpoint ignores it.demos/preview.png— add the 640×480 thumbnail thatog:imageand the oEmbedthumbnail_urlboth reference. It previously 404'd, so every card-fallback showed a broken image. Captured from the live player mid-playback, so it shows the video + captions + the interactive transcript with an active word highlighted.Not changed
oembed.json— already a valid rich response; its only defect was the missing thumbnail file, resolved by addingpreview.png. No edit needed.?url=handling (demos: oEmbed/embed metadata gaps blocking rich-player resolution on third-party platforms #285 item 3) — left as noted-optional; no current consumer requires a dynamic endpoint. Can be a follow-up Cloudflare Worker if one ever complains.Verify after merge (Pages redeploys from
main)curl -sI …/demos/preview.png→200(currently404)…/demos/embed.html: Iframely tab returns a rich player and the thumbnail row shows the real image, not a broken-image icon<link>present in servedembed.htmlNote (see #285 for detail)
This unblocks oEmbed/OpenGraph consumers that support rich embeds. It does not address Leaflet specifically — Leaflet doesn't render arbitrary HTML embeds at all; that integration is a separate native-block / standard.site track.