Fixed mktemp call and forced replacement of .sdirs file in _purge_lines#15
Open
2suggestions wants to merge 1 commit intohuyng:masterfrom
2suggestions:master
Open
Fixed mktemp call and forced replacement of .sdirs file in _purge_lines#152suggestions wants to merge 1 commit intohuyng:masterfrom 2suggestions:master
2suggestions wants to merge 1 commit intohuyng:masterfrom
2suggestions:master
Conversation
…ent of old .sdirs file in _purge_line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 136 in bashmarks.sh didn't include any X's as a template when calling mktemp, causing it to error out in my environment and close the terminal when attempting to save a bookmark.
In addition, I had 'mv' aliased for 'mv -i', so line 141 which replaces the $HOME/.sdirs file with the new version was prompting for a confirmation on each bookmark save. I've changed it to 'mv -f' to avoid this for others in the same situation.
Cheers, loving the tool :)