Validate Super-Tuning index persistence across adapters - #3665
Open
DaoyuanLi2816 wants to merge 1 commit into
Open
Validate Super-Tuning index persistence across adapters#3665DaoyuanLi2816 wants to merge 1 commit into
DaoyuanLi2816 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_precomputed_indicesvalues, because index persistence is shared by the model's buffer dictionaryCloses #3660.
Coordination
Approved by @BenjaminBossan in #3660 (comment).
Tests
pytest tests/test_initialization.py -k TestSupertuningInitialization -q --no-cov --regression(5 passed)pytest tests/ -k supertuning -q --no-cov --regression(697 passed, 227 skipped, 35476 deselected)git diff --checkpassedAI assistance
I used Codex to help investigate, draft, and test this change. I reviewed every changed line, understand and can defend the change, and ran the tests listed above.