Skip to content

[tests] add FA3 smoke tests - #1132

Merged
sayakpaul merged 5 commits into
mainfrom
fa3-smoke-tests
Sep 4, 2026
Merged

[tests] add FA3 smoke tests#1132
sayakpaul merged 5 commits into
mainfrom
fa3-smoke-tests

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Expose ops so that we can do the testing of backward
  • Bump version since we are exposing something new

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Sep 2, 2026
@sayakpaul

sayakpaul commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn3

@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn3
Mode: build only
Target branch: pr-1132
PR head SHA: 6de1e8e1c6dd71883b0389a81966f21a0f578c13
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@danieldk

danieldk commented Sep 3, 2026

Copy link
Copy Markdown
Member

/kernel-bot build flash-attn3

@danieldk

danieldk commented Sep 3, 2026

Copy link
Copy Markdown
Member

Building again, because tests should now actually run.

@github-actions

github-actions Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn3
Mode: build only
Target branch: pr-1132
PR head SHA: 6de1e8e1c6dd71883b0389a81966f21a0f578c13
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul
sayakpaul marked this pull request as ready for review September 4, 2026 04:22
danieldk
danieldk reviewed Sep 4, 2026
View reviewed changes
Comment thread flash-attn3/tests/test_flash_attn.py Outdated
apply_rotary_emb = None

flash_attn3 = kernels.get_kernel("kernels-community/flash-attn3", version=1)
flash_attn3_ops = importlib.import_module("._ops", package=flash_attn3.__name__)

@danieldk danieldk Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really flaky. Maybe we should consider exposing ops?

@sayakpaul sayakpaul Sep 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 100 percent.

danieldk
danieldk reviewed Sep 4, 2026
View reviewed changes

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment.

@sayakpaul

sayakpaul commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn3

@github-actions

github-actions Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn3
Mode: build only
Target branch: pr-1132
PR head SHA: 8fe5260599b0a900c7b7e00df577acecf192a400
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul sayakpaul closed this Sep 4, 2026
@sayakpaul sayakpaul reopened this Sep 4, 2026
@sayakpaul

sayakpaul commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

/kernel-bot build flash-attn3

@github-actions

github-actions Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build flash-attn3
Mode: build only
Target branch: pr-1132
PR head SHA: 561d07a0fdc3f6d14b197e48d12252458e32a044
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

danieldk
danieldk approved these changes Sep 4, 2026
View reviewed changes

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge if CI is happy.

@sayakpaul
sayakpaul merged commit 2cd21c4 into main Sep 4, 2026
7 of 8 checks passed
@sayakpaul
sayakpaul deleted the fa3-smoke-tests branch September 4, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieldk danieldk danieldk approved these changes

Assignees

No one assigned

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sayakpaul @danieldk