Fix size_str(0) returning "Unknown size" instead of "0 bytes"#8315
Open
Sreekant13 wants to merge 1 commit into
Open
Fix size_str(0) returning "Unknown size" instead of "0 bytes"#8315Sreekant13 wants to merge 1 commit into
Sreekant13 wants to merge 1 commit into
Conversation
size_str used `if not size_in_bytes` to detect an unknown size, which also treats 0 as unknown. But 0 is a valid size, and the docstring states that only `None` means "Unknown size". Check `size_in_bytes is None` instead, so a 0-byte size renders as "0 bytes". Add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size_strusesif not size_in_bytes:to return"Unknown size", which also catches0. But0is a valid size (0 bytes), and the docstring states that onlyNonemeans "Unknown size". So a 0-byte size (e.g. an empty split) currently renders as "Unknown size":This checks
size_in_bytes is Noneinstead. Added a regression test coveringNone,0, and non-zero sizes.