fix(data_loader): handle dataloaders missing batch_sampler attribute - #4179
Open
SparshM8 wants to merge 1 commit into
Open
fix(data_loader): handle dataloaders missing batch_sampler attribute#4179SparshM8 wants to merge 1 commit into
SparshM8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes issue #882 where
prepare_data_loader(and consequentlyAccelerator.prepare) fails with anAttributeErrorwhen aDataLoaderobject does not have abatch_samplerattribute. While standard PyTorchDataLoaderobjects always have this attribute, some custom or wrapped dataloaders might not, causing crashes inaccelerate.Changes
get_samplerhelper to safely accessbatch_samplerusinggetattr.prepare_data_loaderto usegetattr(dataloader, "batch_sampler", None)instead of direct access.tests/test_issue_882.pythat simulates a dataloader without abatch_samplerattribute.Validation
Fixes #882