Handle missing milestone state in issue events - #2316
Open
subotac wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
=========================================
Coverage 85.41% 85.41%
Complexity 2568 2568
=========================================
Files 242 242
Lines 7576 7577 +1
Branches 399 399
=========================================
+ Hits 6471 6472 +1
Misses 869 869
Partials 236 236 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle partial issue-event milestone payloads that omit
state. Missing values now returnnull, while unknown non-null values useGHMilestoneState.UNKNOWNthroughEnumUtils.Includes a regression using the existing issue-event WireMock fixture.
Fixes #2028.
REST schema: https://docs.github.com/en/rest/issues/events?apiVersion=2022-11-28#list-issue-events
Before submitting a PR
mvn -D enable-ci clean installpasses, including SpotBugs and JaCoCo checkssitegeneration exceeded a 20-minute timeout while downloading its cold reporting dependency graph; all preceding build gates passedmainWhen creating a PR
Fixes #2028and the relevant REST schema link