forked from ultralytics/ultralytics
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade zipp from 3.15.0 to 3.19.1 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
2
commits into
main
Choose a base branch
from
snyk-fix-8b0983d662a350a57ecb6241b9763ffd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ | |
|
|
||
| ultralytics | ||
| transformers | ||
| zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning
zipphere is a good immediate fix for the security vulnerability. However, this manual addition of a transitive dependency highlights a larger issue with thisrequirements.txtfile. As the Snyk warning in the PR description shows, many dependencies (likenumpy,torch,scipy) are missing from this list. This can lead to non-reproducible builds and makes dependency management difficult.For more robust dependency management, I recommend using a tool like
pip-toolsto generate a fully-pinnedrequirements.txtfrom arequirements.infile. This ensures that all direct and transitive dependencies are explicitly listed and version-locked, which improves build reproducibility and simplifies security patching.A
requirements.infile would look like this:Then, running
pip-compile requirements.inwould generate a completerequirements.txt.