[Snyk] Fix for 4 vulnerabilities

[q1blue]

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• packages/cli/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Use of a Cryptographic Primitive with a Risky Implementation SNYK-JS-ELLIPTIC-14908844	146
	Cross-site Scripting (XSS) SNYK-JS-REMIXRUNROUTER-14908530	134
	Open Redirect SNYK-JS-REACTROUTER-14908286	114
	Open Redirect SNYK-JS-REMIXRUNROUTER-14908287	114

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect
🦉 Cross-site Scripting (XSS)

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving four identified vulnerabilities in its yarn dependencies. The changes involve updating specific @backstage package versions in the packages/cli/package.json file to their secure counterparts. Reviewers should pay close attention to the manual yarn.lock update requirement and potential impacts on zero-install environments.

Highlights

• Vulnerability Fixes: This pull request addresses 4 identified security vulnerabilities within the project's yarn dependencies, including high-severity Cross-site Scripting (XSS) and Open Redirect issues, as well as a medium-severity cryptographic primitive vulnerability.
• Dependency Updates: The packages/cli/package.json file has been updated to specify exact versions for @backstage/catalog-model (now 0.1.1), @backstage/config-loader (now 0.1.1), and @backstage/release-manifests (now 0.0.1), moving away from workspace:^ declarations to resolve the vulnerabilities.
• Manual yarn.lock Update Required: A warning indicates that the yarn.lock file was not automatically updated by Snyk and requires manual intervention before this pull request can be merged successfully.
• Zero-Install Consideration: For projects utilizing Yarn's zero-install feature, it is necessary to run yarn after pulling these changes to update the .yarn/cache/ directory, as this PR does not include those updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[snyk-io]

⛔ Snyk checks have failed. 1 issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (1)
⛔	Open Source Security	0	0	1	0	1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[entelligence-ai-pr-reviews]

Walkthrough

Changes

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant CLI as @backstage/cli
    participant Registry as npm Registry
    participant CM as @backstage/catalog-model
    participant CL as @backstage/config-loader
    participant RM as @backstage/release-manifests

    Note over Dev,RM: Dependency Resolution Change: workspace:^ → specific versions

    Dev->>CLI: Update package.json dependencies
    Note over CLI: catalog-model: workspace:^ → 0.1.1<br/>config-loader: workspace:^ → 0.1.1<br/>release-manifests: workspace:^ → 0.0.1
    
    Dev->>PM: Run install command
    
    alt Before Change (workspace:^)
        PM->>CLI: Resolve workspace dependencies
        PM->>CM: Link local workspace package
        PM->>CL: Link local workspace package
        PM->>RM: Link local workspace package
        Note over PM,RM: Uses local monorepo versions
    else After Change (specific versions)
        PM->>Registry: Request @backstage/catalog-model@0.1.1
        Registry-->>PM: Return package tarball
        PM->>CLI: Install catalog-model@0.1.1
        
        PM->>Registry: Request @backstage/config-loader@0.1.1
        Registry-->>PM: Return package tarball
        PM->>CLI: Install config-loader@0.1.1
        
        PM->>Registry: Request @backstage/release-manifests@0.0.1
        Registry-->>PM: Return package tarball
        PM->>CLI: Install release-manifests@0.0.1
        
        Note over PM,RM: Uses published registry versions
    end
    
    PM-->>Dev: Dependencies installed
    Note over Dev,CLI: CLI now uses fixed versions<br/>instead of workspace links

Loading

▶️ ⚡ AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf

Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @entelligenceai + *your message*

Example: @entelligenceai Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @entelligenceai + *feedback*

Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

1. config - shows the current config
2. retrigger_review - retriggers the review

More commands to be added soon.

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, attempts to fix four security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace-protocol dependencies (workspace:^) with pinned, outdated versions from npm, which will likely break the build and cause other issues. I have left a critical comment with a detailed explanation and a suggested alternative approach using Yarn's resolutions feature, which is the correct way to handle transitive dependency vulnerabilities in this context.

[gemini-code-assist]

These changes incorrectly replace workspace:^ dependencies with old, fixed versions from the npm registry. This is problematic for several reasons:

1. Breaks Monorepo Structure: It defeats the purpose of a monorepo using Yarn workspaces, which is to use the local, in-repo versions of packages.
2. Significant Downgrades: The pinned versions are major downgrades from the current versions in the workspace. For example, @backstage/catalog-model is being downgraded from 1.4.1 to 0.1.1.
3. Build Failures: This will likely lead to build failures or runtime errors due to API incompatibilities.

The PR description also mentions that yarn.lock could not be updated, which further indicates that these changes are incorrect.

To fix the underlying security vulnerabilities in transitive dependencies, you should use Yarn's resolutions feature in the root package.json file to force a non-vulnerable version of the transitive dependency across the entire monorepo. For example:

// In root package.json
"resolutions": {
  "elliptic": "^6.5.5",
  "@remix-run/router": "^1.15.0",
  "react-router": "^6.18.0"
}

Please revert these changes and apply the fix using resolutions. After adding the resolutions, run yarn install to update the yarn.lock file.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/cli-common": "workspace:^",
    "@backstage/cli-node": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/config-loader": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/eslint-plugin": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/release-manifests": "workspace:^"