[Snyk] Fix for 4 vulnerabilities

[q1blue]

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• plugins/catalog-backend-module-openapi/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Use of a Cryptographic Primitive with a Risky Implementation SNYK-JS-ELLIPTIC-14908844	146
	Cross-site Scripting (XSS) SNYK-JS-REMIXRUNROUTER-14908530	134
	Open Redirect SNYK-JS-REACTROUTER-14908286	114
	Open Redirect SNYK-JS-REMIXRUNROUTER-14908287	114

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect
🦉 Cross-site Scripting (XSS)

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the security posture of the project by addressing four critical vulnerabilities within the plugins/catalog-backend-module-openapi module. It achieves this by updating several @backstage dependencies to newer, more secure versions. The changes are concentrated on package.json to reflect these dependency bumps, aiming to mitigate risks associated with cryptographic primitive misuse, cross-site scripting, and open redirects.

Highlights

• Automated Security Fix: This pull request was automatically generated by Snyk to address four identified security vulnerabilities within the project's yarn dependencies.
• Dependency Updates: Key @backstage dependencies in plugins/catalog-backend-module-openapi/package.json have been updated from workspace:^ to specific versions to resolve these vulnerabilities.
• Vulnerabilities Addressed: The fixes target a medium-severity 'Use of a Cryptographic Primitive with a Risky Implementation' and three high-severity issues: 'Cross-site Scripting (XSS)' and two 'Open Redirect' vulnerabilities.
• Manual yarn.lock Update Required: A warning indicates that the yarn.lock file was not automatically updated and requires manual intervention before merging this PR.
• Zero-Install Consideration: Users leveraging Yarn's zero-installs feature will need to run yarn locally to update their .yarn/cache directory after pulling these changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	react@​17.0.2
	storybook-dark-mode@​1.1.2
	react-hot-loader@​4.13.1
	swc-loader@​0.2.3
	typescript@​4.7.4
	react-dom@​17.0.2

View full report

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		License policy violation: npm polished under OFL-1.1 License: OFL-1.1 - the applicable license policy does not allow this license (4) (package/docs/assets/fonts/LICENSE.txt) From: ? → npm/@storybook/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: npm typescript under W3C-20150513 License: W3C-20150513 - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: CC-BY-4.0 - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: LicenseRef-W3C-Community-Final-Specification-Agreement - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) License: MIT-Khronos-old - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt) From: storybook/package.json → npm/[email protected] ℹ Read more on: This package | This alert | What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[entelligence-ai-pr-reviews]

Walkthrough

Changes

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Client
    participant OpenAPIModule as OpenAPI Catalog Module
    participant CatalogBackend as Catalog Backend<br/>(v1.25.0)
    participant BackendCommon as Backend Common<br/>(v0.24.1)
    participant Config as Config Service<br/>(v0.1.1)
    participant Integration as Integration Service
    participant RefParser as JSON Schema Ref Parser

    Note over OpenAPIModule: Dependency versions updated<br/>from workspace to fixed versions

    Client->>OpenAPIModule: Request OpenAPI spec processing
    activate OpenAPIModule
    
    OpenAPIModule->>Config: Load configuration
    activate Config
    Config-->>OpenAPIModule: Return config settings
    deactivate Config
    
    OpenAPIModule->>Integration: Resolve spec location
    activate Integration
    Integration-->>OpenAPIModule: Return spec URL/path
    deactivate Integration
    
    OpenAPIModule->>RefParser: Parse OpenAPI spec with refs
    activate RefParser
    RefParser-->>OpenAPIModule: Return resolved schema
    deactivate RefParser
    
    OpenAPIModule->>CatalogBackend: Register API entities
    activate CatalogBackend
    CatalogBackend->>BackendCommon: Use common utilities
    activate BackendCommon
    BackendCommon-->>CatalogBackend: Provide logging, auth, etc.
    deactivate BackendCommon
    CatalogBackend-->>OpenAPIModule: Confirm registration
    deactivate CatalogBackend
    
    OpenAPIModule-->>Client: Return processed entities
    deactivate OpenAPIModule

Loading

▶️ ⚡ AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf

Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @entelligenceai + *your message*

Example: @entelligenceai Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @entelligenceai + *feedback*

Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

1. config - shows the current config
2. retrigger_review - retriggers the review

More commands to be added soon.

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, aims to fix four security vulnerabilities by updating dependencies. However, the proposed changes in plugins/catalog-backend-module-openapi/package.json replace workspace:^ specifiers with pinned versions for several internal packages. This is a significant issue in a monorepo setup as it breaks the local development workflow. Additionally, the pull request description states that the yarn.lock file failed to update, which is a critical problem. The proposed changes should be reverted, and the vulnerabilities should be addressed in a way that is compatible with the project's monorepo structure.

[gemini-code-assist]

Pinning these workspace dependencies to specific versions breaks the monorepo structure. The workspace:^ protocol is used to ensure that local packages are used during development, allowing for changes in one package to be immediately available to others that depend on it. By pinning to a specific version, you are forcing this package to use a published version from the registry, which will cause inconsistencies and break local development workflows.

While the goal is to fix security vulnerabilities, this approach is problematic. A better way would be to identify the vulnerable transitive dependencies and update them, potentially by updating the versions of the workspace packages themselves and then regenerating the yarn.lock file.

The PR description also notes that yarn.lock was not updated, which is a critical issue that must be resolved before merging. It's recommended to revert these changes and address the vulnerabilities in a way that respects the monorepo setup.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-backend": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^"

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!