-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/plugin-catalog from 0.0.0-use.local to 0.1.1 #10033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908530 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908286 - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908287
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading a critical dependency. The upgrade targets specific vulnerabilities within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix security vulnerabilities by changing the version of @backstage/plugin-catalog. However, the proposed change from workspace:^ to a fixed version 0.1.1 is a major downgrade from the current workspace version (1.12.1-next.0) and will likely break the application. I've left a comment suggesting to revert this change. The correct approach would be to update the dependencies of the @backstage/plugin-catalog package within your monorepo. Additionally, as noted in the PR description, the yarn.lock file has not been updated, which is required after any dependency change.
| }, | ||
| "dependencies": { | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-catalog": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces the workspace dependency on @backstage/plugin-catalog with a pinned, very old version (0.1.1). The local version of @backstage/plugin-catalog in this monorepo is 1.12.1-next.0 (as seen in plugins/catalog/package.json). This is a significant downgrade and will likely cause build failures or runtime errors due to API incompatibilities.
Using workspace:^ ensures you are using the code from your local monorepo, which is the intended setup. Pinning to an external version, especially a very old one, breaks this. The correct way to fix the underlying security vulnerabilities is likely to update the dependencies within the local @backstage/plugin-catalog package itself.
| "@backstage/plugin-catalog": "0.1.1", | |
| "@backstage/plugin-catalog": "workspace:^", |
WalkthroughChangesSequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant Reg as NPM Registry
participant Plugin as catalog-customized
Dev->>PM: Install dependencies
PM->>Plugin: Read package.json
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/plugin-catalog
WS-->>PM: Return local workspace version
PM->>Plugin: Link workspace dependency
else After Change (0.1.1)
PM->>Reg: Fetch @backstage/[email protected]
Reg-->>PM: Return version 0.1.1
PM->>Plugin: Install specific version
end
PM-->>Dev: Dependencies installed
Note over Plugin: Plugin now uses pinned version<br/>instead of workspace reference
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/catalog-customized/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-REMIXRUNROUTER-14908530
SNYK-JS-REACTROUTER-14908286
SNYK-JS-REMIXRUNROUTER-14908287
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect
🦉 Cross-site Scripting (XSS)