Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/azure-devops/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-azure-devops-common": "workspace:^",
"@backstage/plugin-azure-devops-common": "0.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change appears to be incorrect. It replaces workspace:^ with a pinned version 0.0.1 for @backstage/plugin-azure-devops-common. This is a significant downgrade, as the version of this package within the workspace is 0.3.0 (as seen in plugins/azure-devops-common/package.json).

Using workspace:^ is the correct approach in this monorepo to ensure that the local package from the workspace is used. Pinning to an old version will likely cause build failures or runtime errors, and it goes against the intended structure of the project's dependencies.

This automated change by Snyk seems to be based on a misunderstanding of the project's setup. The PR should be rejected, or the change should be reverted to use workspace:^.

Suggested change
"@backstage/plugin-azure-devops-common": "0.0.1",
"@backstage/plugin-azure-devops-common": "workspace:^",

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading