Repository navigation
V0.2 with ValuesType - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateStaticReadonlyCollectionwith a newValuesTypesetting (FancyEnumValuesType), available on the enum, on the assembly and as the MSBuild propertyFancyEnumValuesType:Span(default):Valuesis aReadOnlySpan<T>over static data in the assembly, with no allocation, no copy and no static field. Needs .NET 7+;byte/sbyteenums get it on every target.InlineArray: 0.1's behavior, a storable[InlineArray]copy, plusAsSpan.StaticCollection: a cachedIReadOnlyList<T>, plusAsSpan, on every target.ValuesTypecan't be generated for the target.Valuesis skipped for that target only, so multi-targeted builds still pass.NoInlineArrayto just the[InlineArray]struct.{Enum}Arrayis now generated only for flags enums (ListFlagMembers) andValuesType = InlineArray.Inline, where the generatedInlineArraystruct shadowed the attribute alias. The attribute is now fully qualified.ValuesTypescenarios on .NET 10 and netstandard2.0, HENUM017 cases, and runtime checks (static data, independent copies, survivingawait). The package smoke test now covers abyteenum on net48.ValuesBenchmarksrow perValuesType.CHANGELOG.mdwith 0.1 → 0.2 upgrade notes.