refactor: api router declaration & tenant auth scope #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
force-pushed
the
refactor-auth
branch
from
7005479 to
89f446b
Compare
alexbouchardd
approved these changes
Jan 30, 2026
alexluong
force-pushed
the
refactor-models
branch
from
75564a9 to
c52bfaa
Compare
ErrInvalidBearerToken now returns 401 instead of 400 — a malformed bearer token is an authentication failure, not a bad request. Add expired JWT tests for Extract, TenantJWTAuthMiddleware, and APIKeyOrTenantJWTAuthMiddleware. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replace AuthScope/RouteMode with simpler AuthMode enum and TenantScoped bool. Flatten 5 route slices into 2 (nonTenantRoutes + tenantRoutes) with portal routes conditionally appended. Auto-apply RequireTenantMiddleware via TenantScoped instead of manual Middlewares arrays. Define narrow TenantRetriever interface to decouple middleware from full TenantStore. Change mustTenantFromContext to panic on missing tenant (programming bug, not user error). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
… mustTenantIDFromContext
- Remove 3 dead symbols from auth_middleware.go
- Remove TestSetTenantIDMiddleware from auth_middleware_test.go
- RequireTenantMiddleware reads c.Param("tenantID") instead of c.Get
- Remove SetTenantIDMiddleware() from router global middleware
- Upsert handler uses c.Param("tenantID") directly
Co-Authored-By: Claude Opus 4.5 <[email protected]>
alexluong
force-pushed
the
refactor-auth
branch
from
addc188 to
8cf2d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #643