Prevent blocking when remote is not reachable#89
Open
Seneral wants to merge 1 commit intohoijui:masterfrom
Open
Prevent blocking when remote is not reachable#89Seneral wants to merge 1 commit intohoijui:masterfrom
Seneral wants to merge 1 commit intohoijui:masterfrom
Conversation
Configured OSCPortOut using UDP to never block This happens on e.g. linux, blocking for up to 3s when remote is unreachable In the spirit of UDP "send and forget", it should be non-blocking Any packets may be queued by OS or dropped, we don't care
Author
|
In case there are concerns with backwards-compatibility, I've made a separate branch that simply exposes configureBlocking, requiring applications to opt-in to this change: One of these changes, perhaps both, is very much desired though. Thank you! |
Seneral
added a commit
to Seneral/SlimeVR-Server
that referenced
this pull request
May 6, 2026
This freezes the whole server when target is unreachable Observed on Linux with freezes of 3s with every send This requires a patch to JavaOSC and thus upstream cooperation: hoijui/JavaOSC#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR configures OSCPortOut (using connect function) using UDP to never block
This happens on e.g. linux, blocking for up to 3s when remote is unreachable while the system tries to reach the target
In the spirit of UDP "send and forget", it should be non-blocking
Any packets may be queued by OS or dropped, we don't care
A lot of applications will not be written to handle this because it really only happens when it is misconfigured or used in non-operating conditions, and can thus cause undesired behaviour like freezing