feat(s3)!: add hitbox-s3 backend and unified ValueEnvelope#288
Open
AndreyErmilov wants to merge 2 commits into
Open
feat(s3)!: add hitbox-s3 backend and unified ValueEnvelope#288AndreyErmilov wants to merge 2 commits into
AndreyErmilov wants to merge 2 commits into
Conversation
|
…prefix
Address review feedback on the hitbox-s3 backend:
- Remove unused `tokio` and `tracing` from `[dependencies]` (tokio was only
needed by tests and is already a dev-dependency; tracing was never used).
- Preserve the original AWS SDK error as the `source` of `S3Error::S3`
instead of stringifying it, so callers can downcast/inspect the chain
(e.g. throttling vs. 5xx vs. fatal).
- Trim a trailing slash from the key prefix so `prefix("cache/")` no longer
yields double-slash object keys; add a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.