[DEVIN: Konsti] Fix failing E2E tests: CLI error string and MCP prompt name#1439
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
[DEVIN: Konsti] Fix failing E2E tests: CLI error string and MCP prompt name#1439devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- cli.test.ts: Update expected error from 'File not found' to 'Config file not found' to match actual CliError message - mcp.test.ts: Update expected prompt name from 'ask_stack_auth' to 'skill' to match MCP handler implementation Co-Authored-By: Konstantin Wohlwend <n2d4xc@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR fixes two E2E test assertions that were mismatched against their implementations. Both corrections are verified against the source code they test.
Confidence Score: 5/5Both test fixes are straightforward assertion corrections verified against the actual implementation — safe to merge. Each changed assertion was confirmed against the source it tests: the CLI error string matches the exact CliError message in config-file-path.ts, and 'skill' matches the prompt name registered in mcp-handler.ts. No logic, no runtime paths, and no application code are modified. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as E2E Test
participant CLI as stack-cli (init --mode link-config)
participant CFP as config-file-path.ts
participant MCP as mcp-handler.ts
Note over Test,CFP: CLI test fix
Test->>CLI: run with --config-file /nonexistent/stack.config.ts
CLI->>CFP: "resolveConfigFilePathOption(path, {mustExist: true})"
CFP-->>CLI: throw CliError("Config file not found: ...")
CLI-->>Test: stderr contains "Config file not found" ✓
Note over Test,MCP: MCP test fix
Test->>MCP: prompts/list request
MCP-->>Test: "[{name: "skill"}]"
Test->>Test: "assert name === "skill" ✓"
Reviews (1): Last reviewed commit: "Fix failing E2E tests: update CLI error ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two deterministic E2E test failures on the dev branch:
CLI test (apps/e2e/tests/general/cli.test.ts:611): The test expected 'File not found' but the actual CliError message is 'Config file not found: ...'. Updated to match the real error message from packages/stack-cli/src/lib/config-file-path.ts.
MCP test (apps/e2e/tests/backend/endpoints/api/v1/internal/mcp.test.ts:114): The prompts/list test expected prompt name 'ask_stack_auth' but the MCP handler registers the prompt as 'skill' (apps/mcp/src/mcp-handler.ts:94). Updated the test to match the implementation.
These two failures were consistent across all E2E test workflows (regular, local emulator, custom port prefix). Other failures in CI appear to be timeouts/flaky tests that also occur on main.