-
Notifications
You must be signed in to change notification settings - Fork 9
feat: ingestion #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ingestion #64
Conversation
787ecc3 to
93d867d
Compare
|
Apparently the errors are caused by Apollo client not being supported in Node v14 and v16 |
jeremymwells
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One small suggestion.
Also wondering if we should either 1) take a directory as a flag, or 2) prompt the user to run in the root of the project. Apologize if I've missed that.
dwelch2344
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Few thoughts/suggestions. Alll are up for debate (minus the url config and user-agent bit)
0a56671 to
c4e592c
Compare
I'd add that as next step and pass it as argument like |
9839f5b to
4d48bb8
Compare
4d48bb8 to
4a88385
Compare
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments/suggestions. Otherwise lgtm 👍
Co-authored-by: George Kalpakas <[email protected]>
Co-authored-by: George Kalpakas <[email protected]>
Co-authored-by: George Kalpakas <[email protected]>
Co-authored-by: George Kalpakas <[email protected]>
Co-authored-by: George Kalpakas <[email protected]>
9718bb0 to
146d4e0
Compare
146d4e0 to
e2b3c4b
Compare
|
It breaks v14 and v16 💀 trying to investigate |
76fd748 to
87626db
Compare
87626db to
0298f7c
Compare
|
basically in pre-18 node versions there is no |
This features allows customer to send their package.json.
Bikeshedding or error messages, prompts, naming welcome 😄