fix: change CORS whitelist domain matching logic#59
Open
budakhasan wants to merge 1 commit intohepsiburada:masterfrom
Open
fix: change CORS whitelist domain matching logic#59budakhasan wants to merge 1 commit intohepsiburada:masterfrom
budakhasan wants to merge 1 commit intohepsiburada:masterfrom
Conversation
Previously, `Array.map` was used instead of `Array.some`, causing the whitelist check to always return a truthy array rather than validating the origin. Replace with `some` and strict matching that allows exact domain matches, subdomains, and protocol-prefixed origins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Array.mapwas used instead ofArray.some, causing the whitelist check to always return a truthy array rather than validating the origin. Replace withsomeand strict matching that allows exact domain matches, subdomains, and protocol-prefixed origins.