feat: POWER-4854 - Add sag and clearance#100
Conversation
- Add missing trailing period to summary - Align lineId param description with implementation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prebz98
force-pushed
the
feat/POWER-4854-Add-sag-and-clearance-method
branch
from
847570f to
d102456
Compare
|
Suggestion: Consider removing SagAndClearanceUrl.cs and the InternalsVisibleTo attribute from the .csproj. The URL builder tests verify string interpolation and query param logic that's shared with every other endpoint (icing, conductor temperature, etc.), none of which have URL unit tests today. The BuildLatestSagAndClearanceUrl method follows the exact same pattern as BuildLatestIcingUrl, so there's no unique logic to protect against. Adding InternalsVisibleTo to expose internals to the test project sets a precedent we don't use elsewhere in the SDK, and the tests don't justify it here. If we want test coverage for this endpoint, an integration test following the existing GetAssets pattern would be more valuable, as it would verify the full round-trip (auth, URL construction, deserialization) through the public API rather than testing string constants in isolation. Something like a GetLatestSagAndClearance test under WhenAuthenticated/ |
Prebz98
force-pushed
the
feat/POWER-4854-Add-sag-and-clearance-method
branch
from
d102456 to
378651d
Compare
2 participants
Summary
Add sag and clearance method to the client.
Add examples for dotnet and python sdks.
Add tests for dotnet.