Skip to content

fix(calendar): import Google Meet links of synced Google events - #11150

Open
MichaelUray wants to merge 1 commit into
hcengineering:developfrom
MichaelUray:feat/gcal-meet-link
Open

MichaelUray wants to merge 1 commit into
hcengineering:developfrom
MichaelUray:feat/gcal-meet-link

Conversation

@MichaelUray

Copy link
Copy Markdown
Contributor

Fixes #6848

Problem and change

Incoming Google Calendar sync only copied event.location into the Huly event and ignored hangoutLink / conferenceData, so the Meet link of a Google event was lost in Huly.

When a Google event has no location, the video conference link (hangoutLink, or the video entry point of conferenceData) is now stored as the Huly event location, where the location editor already offers a button to open links. An explicit Google location still takes precedence. The mapping is deterministic, so repeated syncs do not duplicate anything.

On the Huly to Google direction the location diff now compares against the same derived value, so pushing an unrelated Huly edit does not copy the Meet link into the Google location field.

Tests

New unit tests services/calendar/pod-calendar/src/__tests__/conference.test.ts. An end-to-end check needs the calendar service with a Google account: a Google event with a Meet link and no location shows the Meet URL as its location in Huly; an event with its own location keeps it; editing the title in Huly does not write the Meet link into Google's location.

Incoming Google Calendar sync only copied event.location into the Huly event and ignored hangoutLink / conferenceData, so the Meet link of a Google event was lost in Huly.

When a Google event has no location, the video conference link (hangoutLink, or the video entry point of conferenceData) is now stored as the Huly event location, where the location editor already offers a button to open links. An explicit Google location still takes precedence. The mapping is deterministic, so repeated syncs do not duplicate anything.

On the Huly to Google direction the location diff now compares against the same derived value, so pushing an unrelated Huly edit does not copy the Meet link into the Google location field.

Fixes hcengineering#6848

Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Calendar plugin doesn't add google meet links

1 participant