Fix FTDI host multi-channel loop and update documentation#3513
Merged
Fix FTDI host multi-channel loop and update documentation#3513
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in the FTDI multi-channel CDC host driver, corrects a function name typo, and adds comprehensive J-Link GDB Server documentation for RTT logging.
Changes:
- Fixed FTDI multi-channel loop bug where non-zero interface numbers would skip channel assignment, causing incorrect operation for multi-channel FTDI devices
- Corrected spelling of
ftdi_proccess_set_configtoftdi_process_set_configthroughout the codebase - Refactored and improved
cdch_set_configfunction with complete xfer structure initialization and more direct driver invocation - Added detailed J-Link GDB Server + RTT logging instructions to AGENTS.md with practical examples
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/class/cdc/cdc_host.c | Fixed FTDI multi-channel bug by ensuring all interfaces call ftdi_determine_type() to properly set channel numbers; corrected typo in function name; improved cdch_set_config with complete initialization; added clang-format directives for array formatting |
| AGENTS.md | Added comprehensive J-Link GDB Server + RTT logging section with practical commands for building, flashing, launching GDB server, reading RTT output, and capturing logs to files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in sizeNo entries. Changes <1% in size
No changes
|
fix typos for ftdi_process_set_config() add J-Link GDB + RTT logging instructions
hathach
force-pushed
the
fix-cdch-ftdi-mulitple-channel
branch
from
7fce9aa to
da21dab
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes the following updates:
ftdi_process_set_config()function.