GHC-9.0 Support and Semigroup-Monoid Compatability#28
Open
waivio wants to merge 3 commits intohaskell:masterfrom
Open
GHC-9.0 Support and Semigroup-Monoid Compatability#28waivio wants to merge 3 commits intohaskell:masterfrom
waivio wants to merge 3 commits intohaskell:masterfrom
Conversation
…e previously internal (<>) that had a funkey right assoc to (<~>), and added a Semigroup instance. Added the exitsing benchmark to the 'text-format.cabal' file to ease testing. Added CHANGELOG.md to record changes.
Member
|
Thanks @waivio, some of this has been fixed in the fork. Maybe parts of this PR can be salvaged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this lib is actively maintained but, here is updates for GHC-9.0 Support and some previous Semigroup-Monoid Compatibility changes. The library compiles fine and the benchmarks seem to run fine, there is no test suite to test against. This library is a dependency of LiquidHaskell so it would be good to get it running again.