Merged
Conversation
Exception were thrown in case when all sample values are identical and test statistic evaluated to NaN Fixes haskell#148
Shimuuar
force-pushed
the
kruskalagain
branch
from
393c7e1 to
7935236
Compare
Collaborator
|
Merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, changed computers so it was easier for me to work from a clean slate.
This PR Incorporates comments from #227 to fix #148.
None of the function signatures are changed.
kruskalWallisRankcontinues to return the same rank if all input values across all samples are the same.kruskalWallisreturnsNaNif all input values across all samples are the samekruskalWallisTestcatchesNaNto returnNothingif all input values across all samples are the same.