Fix broken pipe during test and gracefully exit the server by soulomoon · Pull Request #4701 · haskell/haskell-language-server

soulomoon · 2025-08-21T22:36:04Z

gracefully exit the server

…eServer

…lds for clarity

…te to use new lsp revision

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

…on pattern

…t and progress reporting

…se loop script

soulomoon · 2025-08-22T19:54:16Z

Key idea:

Wait for the refactor loop to finish in shutdown handler.
After sending the shutdown response, stop sending further response to client. (This is done in lsp)

…ith a more flexible flaky-test-loop script, update test patterns handling, and improve logging and exit code interpretation.

The worker thread checks this flag before dequeuing each job; if set, it exits immediately, ensuring that no new work is started after shutdown is requested. This mechanism is necessary because some downstream code may swallow async exceptions, making 'cancel' unreliable for stopping the thread in all cases. If 'cancel' does interrupt the thread (e.g., while blocked in STM or in a cooperative job), the thread exits immediately and never checks the TMVar; in such cases, the stop flag is redundant.

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

fendor

LGTM, just some residual files that we likely should get rid of

.github/workflows/flakiness.yml

scripts/eventlog_dump.py

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

scripts/flaky-test-loop.sh

scripts/flaky-test-patterns.txt

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

soulomoon · 2026-03-04T18:39:57Z

windows will still see some broken pipes, but it is not caused by the same gracefully exit issue.
For ubuntu pipeline, broken pipes are gone.
@fendor I've clean up the debug files. This patch is ready.

fendor

Thanks, this looks like a big improvement!

I have added a couple of comments, let me know what you think about it and whether I should address any of them myself.

ghcide/src/Development/IDE/Core/WorkerThread.hs

ghcide/src/Development/IDE/LSP/LanguageServer.hs

fendor

Thanks, this looks like a big improvement!

I have added a couple of comments, let me know what you think about it and whether I should address any of them myself.

Co-authored-by: fendor <fendor@users.noreply.github.com>

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

…unctions

…erences

ghcide/src/Development/IDE/Core/WorkerThread.hs

soulomoon · 2026-03-08T09:23:04Z

@fendor Thanks for the review! I’ve addressed the comments and pushed the updates. Please take another look when you have time.

Fix broken pip during test

ae3a5f1

gracefully exit the server

soulomoon linked an issue Aug 21, 2025 that may be closed by this pull request

Tests randomly fail with "Exception: fd:111: hPutBuf: resource vanished (Broken pipe)" (--test-option=-j1 workaround) #1875

Open

soulomoon added 4 commits August 22, 2025 06:57

Consolidate source-repository-package entries in cabal.project

cd83664

Add flakiness testing workflow

c7ad3a2

Update flakiness workflow and fix exit codes in open-close loop script

4d56b39

Update lsp repository tag in cabal.project

9272de3

soulomoon changed the title ~~Fix broken pip during test~~ Fix broken pipe during test Aug 22, 2025

soulomoon added 12 commits August 22, 2025 08:35

Update flakiness.yml

e1a7947

Add InitParameters data type and enhance shutdown handling in Languag…

ed85d9b

…eServer

Rename InitParameters to InitializationContext and update related fie…

100b39e

…lds for clarity

Increase default maximum iterations to 1000 in flakiness workflow

5835ad7

Update cabal.project and LanguageServer for improved logging and upda…

d26ed7f

…te to use new lsp revision

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

c0f6a9b

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Update lsp repository tag to latest commit

1f9cb02

Improve log message for server exit and simplify test failure detecti…

c72d2e7

…on pattern

Fix flakiness test

569d766

Set default max_iter value to 1000 in flakiness test workflow

cb67ec5

Refactor logging in open-close loop script to improve iteration outpu…

56bc03b

…t and progress reporting

Fix exit codes for broken pipe and test failure detection in open-clo…

9f24f2e

…se loop script

soulomoon added 5 commits August 24, 2025 04:31

Refactor flakiness testing workflow: replace open-close loop script w…

8eb7bb5

…ith a more flexible flaky-test-loop script, update test patterns handling, and improve logging and exit code interpretation.

Update lsp repository tag to a447a4f

d233023

Update cabal.project

fe7421e

update CI

7bf694a

Update reactor shutdown logging, and improve shutdown handling

8c17daa

soulomoon mentioned this pull request Aug 26, 2025

Gracefully exit the server haskell/lsp#622

Merged

soulomoon added 3 commits August 26, 2025 21:40

update flaky-test-loop script

6907be0

update lsp rev

0851914

soulomoon changed the title ~~Fix broken pipe during test~~ Fix broken pipe during test and gracefully exit the server Aug 26, 2025

soulomoon added 9 commits February 20, 2026 15:47

Bump lsp, lsp-types, and lsp-test dependencies

99537cf

Prune unnecessary allow-newer constraints

525552a

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

872fac7

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Add file operation options to initialize response capabilities

4e012ad

Remove floskell plugin and associated test suite from cabal file

ddfb874

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

3baff69

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Add websockets-0.13.0.0 to extra-deps in stack-lts22.yaml

323e67c

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

d475f30

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

1d0e623

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

fendor requested changes Mar 2, 2026

View reviewed changes

.github/workflows/flakiness.yml Outdated Show resolved Hide resolved

scripts/eventlog_dump.py Outdated Show resolved Hide resolved

soulomoon added 3 commits March 3, 2026 00:46

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

0db12bc

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

fix import

a7fdae7

Update cabal.project dependencies and remove eventlog_dump.py script

4dbc894

fendor reviewed Mar 2, 2026

View reviewed changes

scripts/flaky-test-loop.sh Outdated Show resolved Hide resolved

fendor reviewed Mar 2, 2026

View reviewed changes

scripts/flaky-test-patterns.txt Outdated Show resolved Hide resolved

soulomoon added 3 commits March 4, 2026 20:50

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

ce98fc6

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Remove flakiness testing workflow and related scripts

99c835e

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

ca5ce66

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

fendor requested changes Mar 7, 2026

View reviewed changes

soulomoon and others added 5 commits March 7, 2026 23:24

Apply suggestions from code review

ebdfddb

Co-authored-by: fendor <fendor@users.noreply.github.com>

fix build

9b7b400

Merge branch 'master' into 1875-tests-randomly-fail-with-exception-fd…

3edac6f

…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround

Add documentation for 'withWorkerQueue' and 'withWorkerQueueSimple' f…

8b1c37b

…unctions

Rename InitializationContext to ServerLifecycleContext and update ref…

9a6bfbe

…erences

fendor reviewed Mar 7, 2026

View reviewed changes

ghcide/src/Development/IDE/Core/WorkerThread.hs Outdated Show resolved Hide resolved

format

6b5fe23

soulomoon requested a review from fendor March 8, 2026 09:21

Uh oh!

Conversation

soulomoon commented Aug 21, 2025

Uh oh!

soulomoon commented Aug 22, 2025

Uh oh!

fendor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

soulomoon commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fendor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fendor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soulomoon commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

soulomoon commented Mar 4, 2026 •

edited

Loading