Conversation
|
Oh I did not see this was not marked as |
ulysses4ever
left a comment
There was a problem hiding this comment.
"cabal.project plugin" looks confusing in the context of the Cabal repository. Please, replace all of its occurrences with "cabal.project HLS plugin" (esp. the changelog).
|
@ffaf1 I consider the review-needed label more of our manegerial stuff (to notify Matrix, review during the meetings, and such) rather than an interface for contributors. In practice (I find), when people don't want reviews, they put the PR in the draft state (mostly) because they don't know about the label. So, if the PR isn't in the draft state, it's safe to assume that it can be reviewed, I think. |
These instances are also useful for the |
|
Looks like there's a couple of rebase conflicts that need to be fixed. |
|
@ffaf1 I resolved your older comments: they were straightforward to address and this was done. We can now move forward. |
fendor
left a comment
There was a problem hiding this comment.
Whitespace change, otherwise, I think you can apply the merge label :)
710c97c to
58cc122
Compare
This PR adds the NFData instances necessary for the HLS plugins to function, as recommended here: haskell/haskell-language-server#4615 (comment)