fix: Allow the JSON parsing of Strings with a null value.#829
Merged
anthony-swirldslabs merged 1 commit intoMay 18, 2026
Merged
Conversation
… to null else to the parsed string. ____________________________________________________________________ Signed-off-by: berryware <231598+berryware@users.noreply.github.com>
Contributor
Author
|
@jsync-swirlds @Nana-EC for visibility |
anthony-swirldslabs
approved these changes
May 18, 2026
Contributor
anthony-swirldslabs
left a comment
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
Looks good to me, @berryware . Thank you!
Contributor
|
This PR will be released in PBJ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Block Node(BN) Team would like to use PBJ, rather than GSON, to parse JSON responses from the Mirror Node(MN) REST API. The MN Response can contain string fields with null values. PBJ throws an exception when parsing null values.
com.hedera.pbj.runtime.ParseException: com.hedera.pbj.runtime.ParseException: java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.tree.TerminalNode.getText()" because the return value of "com.hedera.pbj.runtime.jsonparser.JSONParser$ValueContext.STRING()" is null.
Related issue(s):
Fixes #828
Notes for reviewer:
spotless made some formatting changes in addition to my changes.
Checklist