Repository navigation
Mark the NuGet package as .NET 10 instead of .NET 8 - #6
Merged
Merged
Conversation
NuGet.org shows the lowest net* TFM in the package header, so shipping net8.0 made TypeSafe.AI.Sdk appear as a .NET 8 package. Target net10.0 and netstandard2.0 instead, and stop installing the .NET 8 SDK in CI. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NuGet.org labels a package with the lowest
net*TFM it ships.TypeSafe.AI.Sdktargetednet10.0;net8.0;netstandard2.0, so the gallery header showed .NET 8.0 even though a dedicatednet10.0build was included.This drops the
net8.0target so the package is marked .NET 10.0, while keepingnetstandard2.0for older runtimes. CI/publish/pages no longer install the .NET 8 SDK.Verification
dotnet test -c Release: 73 unit tests passed (2 live integration tests skipped withoutTYPESAFE_API_KEY)lib/net10.0/andlib/netstandard2.0/only (nolib/net8.0/)net10.0assembly advertises.NETCoreApp,Version=v10.0After merge
Publish a new version (for example
v0.3.0) so nuget.org picks up the updated TFMs. Existing0.1.0/0.2.0packages cannot change.