Repository navigation
Conversation
Tracing.StartAsync / StartChunkAsync expanded overloads now return a disposable that discards the trace or chunk, and stopChunk now ends the chunk like upstream. HAR entries take startedDateTime from the browser wall time instead of the float ResourceTiming start time, and WebKit reads the protocol's `walltime` field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream now returns a disposable from
tracing.start()andtracing.startChunk(). Disposing it stops without exporting, so the trace or chunk is thrown away.ITracingcomes from the Microsoft.Playwright package and still returnsTask, so the expanded-parameterStartAsync(name: ...)/StartChunkAsync(name: ...)extensions now return theIAsyncDisposable.stopChunkalso ends the chunk now, the same as upstream. Before, a secondStopChunkAsync(path)quietly wrote an empty trace. Now it throws "Must start tracing before stopping".HAR
startedDateTimeusedResourceTiming.StartTime. That is afloat, so epoch milliseconds were rounded to about two minutes. Entries now use the request's browser wall time instead, the way upstream does withRequest.wallTimeMs(). WebKit was also readingwallTime, but the protocol field iswalltime, so it fell back to the monotonic timestamp.The new pagehide binding test needs no library change. It passes on WebKit and is skipped on Chromium, as upstream's
fixmedoes.Closes #39, closes #51, closes #46
🤖 Generated with Claude Code