Repository navigation
Conversation
Add Locator.Within as a compat extension (upstream locator.within). Port upstream implicit ARIA role mapping so getByRole finds table cells, rows, lists and other elements. Resolve hideHighlight relative to the locator's frame and clear highlights in every frame on page.hideHighlight. Allow '-' in custom selector engine names, as upstream does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream added
locator.within(parent). It is now available as aWithinextension that reads in natural order.page.GetByRole("cell").Nth(1).Within(page.GetByRole("row"))picks the second cell of every row. While porting it, I found that our role engine had no implicit roles for tables, lists, landmarks and many other elements, soGetByRole("cell")matched nothing. The engine now uses upstream's full implicit-role map, including presentation-role inheritance.Highlights now resolve relative to the locator's frame.
frame.Locator(...).HideHighlightAsync()clears the overlay in that frame, andpage.HideHighlightAsync()clears every frame. Custom selector engine names can now contain-, as upstream allows.The regex-flags test is ported too. .NET
Regexhas nogoryflag, so the/foo/gand/foo/ylines use the same pattern as/foo/. The local getBy scripts already resetlastIndex.Closes #36, closes #59, closes #69
🤖 Generated with Claude Code