Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching with the old
proxy: { server: 'per-context' }placeholder broke every context that did not set its own proxy: Chromium got--proxy-server=http://per-context, and pages andcontext.APIRequestfailed withERR_PROXY_CONNECTION_FAILED. Upstream now drops that placeholder at launch, so we do the same in all launch paths, including persistent contexts.This also ports the upstream tests for client certificates with a launch proxy and
proxy.bypass, and forproxy.bypasson fetch redirect targets. Both already passed, because we pick the proxy for each connection.The two
should throw for bad server valuetests are kept as ignored twins. They pass a number asproxy.server, andProxy.Serveris astringin C#, so that case cannot happen here.Closes #34, closes #48, closes #50, closes #53
🤖 Generated with Claude Code