Repository navigation
Conversation
Sets serialize as empty objects, getProperties returns own enumerable data properties only, and Chromium reports thrown null/undefined as "null"/"undefined" like upstream getExceptionMessage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Match playwright-dotnet: build the JS Set in the page instead of mapping ISet<T> arguments to empty objects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six upstream evaluate, console and getProperties tests now run here, and two of them found real gaps.
GetPropertiesAsyncwalked the prototype chain and returned inherited and non-enumerable names. Now it returns only own enumerable data properties, which is what the protocolgetPropertiescall returns upstream. Chromium reportedthrow nullas a bare "Evaluation failed". It now says "null" or "undefined", like upstreamgetExceptionMessage..NET has no JS
Set, so the set-transfer test builds theSetin the page and sends it back as the argument, the way playwright-dotnet handles the sibling Map test. .NET collections still serialize as arrays.Closes #31, closes #40, closes #66
🤖 Generated with Claude Code