Repository navigation
Conversation
A stalled subframe navigation leaves the iframe without an execution context. Style injection, caret hiding and their cleanup each waited up to 5 s for that context, so a screenshot took ~11 s and on loaded Windows runners ran into the target being closed. Upstream uses nonStallingEvaluateInExistingContext for these steps; match that by skipping child frames that have no existing context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SNI-reject server set both ServerCertificate and ServerCertificateSelectionCallback. SslStream rejects that combination with InvalidOperationException before it reads anything, so the server closed every connection right after accept instead of failing the handshake from the SNI callback the way the upstream tls.createServer fixture does. Drop the certificate so the throwing callback runs after the ClientHello arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A screenshot of a page whose iframe navigation is stalled took about 11 seconds. Style injection, caret hiding and their cleanup each waited up to 5 seconds for the stalled frame to get an execution context. On busy Windows runners that window ended with the target closed, which is how
ShouldWorkWhenSubframeHasStalledNavigationfailed on main. Upstream decorates frames withnonStallingEvaluateInExistingContext, so child frames without a live context are now skipped and the test runs in about 1 second.The fixture behind
BrowserShouldNotHangOnTlsErrorsDuringTls12Handshakeset bothServerCertificateandServerCertificateSelectionCallback. SslStream rejects that combination before it reads anything, so the server dropped every connection at accept time. The upstream server fails later, from its SNI callback, after the ClientHello arrives. The fixture now does the same. This fixes a real difference from upstream, but I could not reproduce the CI hang on a warm Linux machine, so this change alone may not make the ubuntu shard green.🤖 Generated with Claude Code