Repository navigation
Conversation
Port upstream isElementVisible: rely on Element.checkVisibility on every browser (it handles nested <details> and unslotted shadow content), with the WebKit list box option workaround. The visible= selector engine now shares the same function, and the role engine uses checkVisibility with upstream's display:contents handling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our visibility check skipped `checkVisibility()` on WebKit and faked `
Details
` with a `closest()` lookup. That missed a closed outer `The `visible=` selector engine had its own copy of the logic and never called `checkVisibility()`. It now uses the same function. The role engine also calls `checkVisibility()` now, and it ports upstream's `display:contents` handling so a `display:contents` button still counts as visible. `locator.Visible()` is added as a shortcut for `Filter(visible: true)`, to match upstream.
Closes #30, closes #58
🤖 Generated with Claude Code